New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-14142][SQL] Replace internal use of unionAll with union #11946

Closed

rxin wants to merge 2 commits into apache:master from rxin:SPARK-14142

Contributor

rxin commented Mar 24, 2016

What changes were proposed in this pull request?

unionAll has been deprecated in SPARK-14088.

How was this patch tested?

Should be covered by all existing tests.


          [SPARK-14142][SQL] Replace internal use of unionAll with union

6479eb4

Contributor Author

rxin commented Mar 24, 2016

davies reviewed

View reviewed changes

sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala

@@ @@ -1361,8 +1361,8 @@ class Dataset[T] private[sql]( @@
                  * by a [[distinct]].
                  *
                  * @group typedrel
-                 * @since 2.0.0
-                 */
+                * @since 2.0.0

Contributor

davies Mar 24, 2016

?

Contributor

davies commented Mar 25, 2016

LGTM, one minor comment


          fix style

922ec43

SparkQA commented Mar 25, 2016

Test build #54117 has finished for PR 11946 at commit 922ec43.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA commented Mar 25, 2016

Test build #54110 has finished for PR 11946 at commit 6479eb4.

This patch fails from timeout after a configured wait of 250m.
This patch merges cleanly.
This patch adds no public classes.

Contributor Author

rxin commented Mar 25, 2016

Merging in master.

asfgit closed this in

3619fec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet